[ENH](storage): Decouple latency stopwatch from tracing - #7658
Open
domenkozar wants to merge 1 commit into
Open
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Storage only needs std::time::Instant and OpenTelemetry histograms for these measurements. Depending on the broader tracing crate pulls the full tracing implementation into storage consumers unnecessarily.
The existing finish method also records once directly and then records again when the consumed stopwatch is dropped. The storage-local implementation tracks completion so each timer contributes exactly one sample.
Validation
The self-contained storage suite passes 11 tests; 27 Tilt-dependent tests are filtered. The S3 and GCS integration targets require external services or credentials.