Document upcoming changes to webhooks payloads#1282
Open
fkorotkov wants to merge 2 commits into
Open
Conversation
These are proposed new fields that will come to the payloads and GraphQL API in the coming weeks. These events will allow to improve export of the events into systems like Datadog. See the following issue: * cirruslabs/cirrus-webhooks-server#8 * cirruslabs/cirrus-webhooks-server#9
edigaryev
suggested changes
Jul 19, 2024
Contributor
There was a problem hiding this comment.
This needs a timestamp field for build's and task's, similarly to audit_event's.
Currently, for build's we only emit a single timestamp, which is build.changeTimestamp, but it doesn't change when the build gets updated.
For tasks we could use the statusTimestamp, but it would be nice to have a uniform timestamp field to avoid ambiguity for the webhook receiver implementors.
Contributor
Author
|
@edigaryev what do you think about a request header. Since the payload is a GraphQL query response and I don't think we can add |
Contributor
That would totally work too. |
Contributor
Contributor
edigaryev
approved these changes
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


These are proposed new fields that will come to the payloads and GraphQL API in the coming weeks.
These events will allow to improve export of the events into systems like Datadog. See the following issue:
timestampof the event upon insert cirrus-webhooks-server#8