⚠️ CONFLICT! Lineage pull request for: skeleton#33
Merged
Conversation
Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4...v5) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
The `pull_request` trigger's default activity types are `opened`, `reopened`, and `synchronized`. These types better represent when we want this workflow to run and the `edited` type was resulting in undesired workflow runs.
This is done automatically with the `pre-commit autoupdate` command.
The latest release supports the artifact-metadata permission that we are now using in the generate-sbom job of the build.yml GitHub Actions workflow in cisagov/skeleton-aws-lambda-python, cisagov/skeleton-docker, and cisagov/skeleton-python-library.
This will return the cache key to being a string with no new lines.
It is no longer necessary to install wheel alongside setuptools as of setuptools v70.1: https://github.com/pypa/wheel?tab=readme-ov-file#historical-note
This is done automatically with the pre-commit autoupdate command.
We rely on the default activity types for the pull_request event in our GitHub Actions workflows. This adds a comment mentioning that we do so and linking to the GitHub documentation for the event which details the specific activity types that are used by default. Co-authored-by: dav3r <david.redmin@gwe.cisa.dhs.gov>
This is done automatically with the pre-commit autoupdate command.
Remove installation of `wheel` Python package
…s/cache-5 Bump actions/cache from 4 to 5
…ggers Adjust the activity types for the `pull_request` trigger in the `Label pull requests` workflow
…ting Adjust the `lint` job of the `build` workflow's cache key formatting
Update `pre-commit` hook versions
This gets rid of several errors from our markdownlint pre-commit linter.
Now that I have two pull requests out for changes relevant to our work it makes sense to use a branch that consolidates any changes we need.
We need to update the comment about using a branch of mcdonnnj's terraform-docs fork to reflect that a second PR with different functionality is now included in the branch. Co-authored-by: Shane Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
…s_branch Change the branch we use for installing terraform-docs
Bumps [crazy-max/ghaction-github-labeler](https://github.com/crazy-max/ghaction-github-labeler) from 5 to 6. - [Release notes](https://github.com/crazy-max/ghaction-github-labeler/releases) - [Commits](crazy-max/ghaction-github-labeler@v5...v6) --- updated-dependencies: - dependency-name: crazy-max/ghaction-github-labeler dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [hashicorp/setup-terraform](https://github.com/hashicorp/setup-terraform) from 3 to 4. - [Release notes](https://github.com/hashicorp/setup-terraform/releases) - [Changelog](https://github.com/hashicorp/setup-terraform/blob/main/CHANGELOG.md) - [Commits](hashicorp/setup-terraform@v3...v4) --- updated-dependencies: - dependency-name: hashicorp/setup-terraform dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
This warning contradicts the Black style so it must be ignored.
Make the ignore commenting consistent with the select commenting. Break up each comment/directive with an empty line.
This adds the flake8-bugbear plugin to our pre-commit configuration. Note that flake8 is already configured to use this plugin's warnings.
Add the dlint plugin to our flake8 configuration for pre-commit. Update the flake8 configuration to select these new warnings.
Add the flake8-noqa plugin to the flake8 portion of our pre-commit configuration. Update the flake8 configuration to select these new warnings.
Add the pep8-naming plugin to the flake8 portion of our pre-commit configuration. Update the flake8 configuration to select these new warnings.
Add the flake8-comprehensions plugin to the flake8 portion of our pre-commit configuration. Update the flake8 configuration to select these new warnings.
When explaining the items selected or ignored in the configuration we now preface each line with the prefix/code it pertains to in the configuration. Also break apart the pycodestyle prefixes into their own lines.
…uration Add additional plugins to the `flake8` pre-commit configuration
…to_lock_terraform_providers Add a pre-commit hook to lock Terraform providers automatically
Update `pre-commit` hook versions
…uration_file Remove the bandit configuration file
Bumps [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws) from 6.36.0 to 6.39.0. - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v6.36.0...v6.39.0) --- updated-dependencies: - dependency-name: hashicorp/aws dependency-version: 6.39.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…sic_usage/hashicorp/aws-6.39.0 Bump hashicorp/aws from 6.36.0 to 6.39.0 in /examples/basic_usage
Lineage pull request for: skeleton
jsf9k
marked this pull request as ready for review
April 9, 2026 20:26
jsf9k
enabled auto-merge
April 9, 2026 20:26
jsf9k
approved these changes
Apr 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Syncs this repository with upstream cisagov/skeleton-tf-module updates, primarily modernizing CI/lint tooling and tightening Python packaging/security scanning configuration.
Changes:
- Update pre-commit hook versions/config (including new flake8 plugins and a pip-audit CVE ignore).
- Refresh GitHub Actions workflow configuration and action versions (labeling, build, etc.).
- Simplify Python bootstrap/requirements (remove
wheel, pinsetuptoolsminimum) and apply minor Markdown formatting updates.
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
setup-env |
Stops upgrading/installing wheel during environment bootstrap. |
requirements.txt |
Removes wheel and sets a minimum setuptools version. |
README.md |
Adjusts Markdown table delimiter formatting (lint-friendly). |
.terraform.lock.hcl |
Updates provider lock hashes (likely due to regenerated lockfile). |
.pre-commit-config.yaml |
Bumps hook versions, adds flake8 plugins, adds pip-audit ignore for a specific CVE, removes Bandit custom config usage, adds terraform providers lock hook. |
.github/workflows/sync-labels.yml |
Updates labeler action major version. |
.github/workflows/label-prs.yml |
Uses default pull_request activity types (removes explicit list) and documents intent. |
.github/workflows/dependency-review.yml |
Documents use of default pull_request activity types. |
.github/workflows/codeql-analysis.yml |
Documents use of default pull_request activity types. |
.github/workflows/build.yml |
Updates cache/action versions, adjusts caching key formatting, updates terraform-docs fork branch usage, removes wheel from pip bootstrap, tweaks go-critic install path. |
.github/labeler.yml |
Removes .bandit.yml from “test” label patterns (file deleted). |
.flake8 |
Expands enabled rule sets and updates ignore list/documentation. |
.bandit.yml |
Removes Bandit configuration file. |
Files not reviewed (1)
- .terraform.lock.hcl: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dav3r
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lineage Pull Request: CONFLICT
Lineage has created this pull request to incorporate new changes found in an upstream repository:
Upstream repository:
https://github.com/cisagov/skeleton-tf-module.gitRemote branch:
HEADCheck the changes in this pull request to ensure they won't cause issues with your project.
The
lineage/skeletonbranch has one or more unresolved merge conflicts that you must resolve before merging this pull request!How to resolve the conflicts
Take ownership of this pull request by removing any other assignees.
Clone the repository locally, and reapply the merge:
Review the changes displayed by the
statuscommand. Fix any conflicts and possibly incorrect auto-merges.After resolving each of the conflicts,
addyour changes to the branch,commit, andpushyour changes:Note that you may append to the default merge commit message that git creates for you, but please do not delete the existing content. It provides useful information about the merge that is being performed.
Wait for all the automated tests to pass.
Confirm each item in the "Pre-approval checklist" below.
Remove any of the checklist items that do not apply.
Ensure every remaining checkbox has been checked.
Mark this draft pull request "Ready for review".
✅ Pre-approval checklist
Note
You are seeing this because one of this repository's maintainers has configured Lineage to open pull requests.
For more information:
🛠 Lineage configurations for this project are stored in
.github/lineage.yml📚 Read more about Lineage