fix: harden GitHub action entrypoints - #11
Closed
epi052 wants to merge 3 commits into
Closed
Conversation
berisher
marked this pull request as draft
March 30, 2026 20:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Harden the GitHub Action entrypoints used to install and run
pickle-fuzzer.This change removes direct input interpolation in the composite action, pins the
third-party actions used by the Atheris mode, constrains action-managed paths to
GITHUB_WORKSPACE, rejects inverted opcode bounds before invocation, andreplaces same-origin checksum trust with GitHub artifact-attestation
verification for downloaded release binaries.
Type of Change
Changes Made
inputs.modevalidation through an environment variable instead ofinterpolating it directly into a
run:block.actions/setup-pythonanddtolnay/rust-toolchainto immutable SHAsfor Atheris mode.
versionfor non-tag action refs, validated release tags,and verified downloaded binaries with
gh attestation verifyagainst therepo release workflow.
output_dir,output_file, and Atheris harness paths to staywithin
GITHUB_WORKSPACE.argssplitting without allowing glob expansion.--mutatorsis present by inserting--before the positional output path.
min_opcodes/max_opcodesbefore invoking the CLI.passed
harness_argsas a split argv array instead of unquoted shell text.whitespace-delimited
harness_args.Testing Performed
Describe the tests you ran to verify your changes:
cargo test)Test commands:
bash -n scripts/action-install.sh scripts/action-run.sh scripts/action-atheris.sh git diff --check cargo fmt --check cargo testManual checks:
scripts/action-install.shrejects invalid release tags such as../../evilscripts/action-run.shrejectsoutput_filevalues that escapeGITHUB_WORKSPACEscripts/action-run.shkeeps positional file arguments separate from repeated--mutatorsscripts/action-atheris.shrejects harness paths outsideGITHUB_WORKSPACEscripts/action-atheris.shinstalls exactly one built wheel and passesharness_argsas a split argv arrayChecklist
Before submitting this PR, please ensure:
cargo fmt)cargo clippy -- -D warnings)cargo test)Performance Impact
If this PR affects performance:
Benchmark results: