fix: harden fuzz workflow inputs - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Harden the fuzz workflow dispatch inputs and crash-check behavior.
This change removes direct
workflow_dispatchinput interpolation from thecustom and thorough fuzzing jobs, constrains the workflow token to read-only
contents access, and makes crash-check steps fail when fuzzing never reached the
artifact-writing phase.
Related Issue
Batch remediation from Hunter campaign
pickle-fuzzer-patch-test:F-0010,F-0011,F-0012,F-0013,F-0014,F-0093Type of Change
Changes Made
permissions: contents: readblock to.github/workflows/fuzz.yml.workflow_dispatchdurationinputs as whole-number seconds beforethey reach shell execution in both the thorough and custom fuzz jobs.
steps through the validated output instead of the raw dispatch input.
fuzz/artifacts/...directory was never created, instead of silently passing.Testing Performed
Describe the tests you ran to verify your changes:
cargo test)Test commands:
Checklist
Before submitting this PR, please ensure:
cargo fmt)cargo clippy -- -D warnings)cargo test)Performance Impact
If this PR affects performance:
Benchmark results:
Screenshots/Examples
Not applicable.
Additional Notes
This PR intentionally stays scoped to
.github/workflows/fuzz.yml. It hardensthe workflow boundary and failure semantics without changing the fuzz targets or
runtime generator behavior.
Breaking Changes
workflow_dispatchnow rejects non-numericdurationvalues and customtargets outside
all_protocolsandvalidate_with_python.