fix: tighten unsafe mutator dispatch - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remediated Hunter findings
F-0039Post-emission rewrites bypass stack and memo re-simulationF-0082Mutator::is_unsafe()was defined but not enforced by generator dispatchF-0085MemoIndexMutator::is_unsafe()claimed safe-mode behavior that can still create invalid memo referencesF-0086OffByOneMutatormutated memo indices despite the safe-mode contractF-0087TypeConfusionMutatoremitted replacements without checking protocol supportF-0088TypeConfusionMutatorsilently degraded into a no-op withoutunsafe_modeF-0089TypeConfusionMutatorrewrote stack-consuming constructors as if they were pure pushesChanges
MutatorKind::requires_unsafe_mutations()and rejectmemoindex/typeconfusionon the CLI unless--unsafe-mutationsis presentallunless unsafe mutations are enabledMemoIndexMutatoras unsafe in all modes and stopOffByOneMutatorfrom touching memo indicesTypeConfusionMutatoras an unsafe-only mutator with protocol-aware replacement encoding, pure-push opcode matching, and replayable replacement descriptionsREADME.mdHow to validate
cargo fmt --checkcargo clippy --all-targets -- -D warningscargo test