Skip to content

Fix DHW, heating, and cooling storage update bugs (issue #156) #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LorenzoBonanni wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

Fix DHW, heating, and cooling storage update bugs (issue #156) #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions citylearn/building.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1669,7 +1669,7 @@ def update_cooling_storage(self, action: float):
Fraction of `cooling_storage` `capacity` to charge/discharge by.
"""

energy = action * self.cooling_storage.capacity
energy = action * self.cooling_storage.capacity * self.algorithm_action_based_time_step_hours_ratio
temperature = self.weather.outdoor_dry_bulb_temperature[self.time_step]

if energy > 0.0:
Expand Down Expand Up @@ -1717,7 +1717,7 @@ def update_heating_storage(self, action: float):
Fraction of `heating_storage` `capacity` to charge/discharge by.
"""

energy = action * self.cooling_storage.capacity * self.algorithm_action_based_time_step_hours_ratio
energy = action * self.heating_storage.capacity * self.algorithm_action_based_time_step_hours_ratio
temperature = self.weather.outdoor_dry_bulb_temperature[self.time_step]

if energy > 0.0:
Expand Down Expand Up @@ -1762,7 +1762,7 @@ def update_dhw_storage(self, action: float):
Fraction of `dhw_storage` `capacity` to charge/discharge by.
"""

energy = action * self.heating_storage.capacity * self.algorithm_action_based_time_step_hours_ratio
energy = action * self.dhw_storage.capacity * self.algorithm_action_based_time_step_hours_ratio
temperature = self.weather.outdoor_dry_bulb_temperature[self.time_step]

if energy > 0.0:
Expand Down