Create Vision Zero incidents list page by johnclary · Pull Request #2074 · cityofaustin/vision-zero

johnclary · 2026-06-30T17:56:47Z

Associated issues

Create Vision Zero incidents list view atd-data-tech#28753

This PR adds a basic VZ incident listing backed by a materialized view. The page is only visible to editors and admins.

Testing

You'll want to replicate from prod if you haven't done so in the last week-ish to make sure you've got the latest VZ incidents.
Apply migrations and metadata: Clock how long it takes to apply this migration. We might want to consider manually applying this materialized view and using a placeholder statement in the migration itself.
Start your VZE
Use the side nav to navigate to the new /incidents list page. It should load normally. Test all the things:

Sort by address column
Show/hide columns using the settings menu (right side of table controls)
Use the date filter presets, and also the custom data range
Search by address, other columns
Use the advanced filter toggles (filter by agency, has/does not have crash report, jurisdiction)

Use the toggle to switch to the map view, click around on some features. Use the hyperlinked incident ID to visit the incident details page
Confirm the incident details page has a breadcrumb and renders text like Incident details page for ID #<some-number>.
Log out, then log in with the credentials called Vision Zero Editor (VZE) Test User: Read-only viewer and confirm that the Incident page is hidden from the side nav.

Ship list

Check migrations for any conflicts with latest migrations in main branch
Confirm Hasura role permissions for necessary access
Code reviewed
Product manager approved

netlify · 2026-06-30T17:56:52Z

✅ Deploy Preview for vzv-staging canceled.

Name	Link
🔨 Latest commit	`257243b`
🔍 Latest deploy log	https://app.netlify.com/projects/vzv-staging/deploys/6a6234ada3152800096cee29

netlify · 2026-06-30T17:57:47Z

✅ Deploy Preview for vze-staging canceled.

Name	Link
🔨 Latest commit	`257243b`
🔍 Latest deploy log	https://app.netlify.com/projects/vze-staging/deploys/6a6234ad4a2bf40008b955ff

johnclary · 2026-07-21T18:21:33Z

+  properties: GeoJsonProperties;
+}
+
+export default function VzMapPopupContent({


I liked searching for Burnet and then toggling the map and seeing most of the incidents lining up with the street, except one or two. The future incident details page is gonna be great

johnclary · 2026-07-21T18:22:50Z

+            id: "other",
+            column: "responding_agencies_str",
+            operator: "_nlike",
+            value: "%$apd$%",


Here's that string-concatenated field coming into play: this is how we find non-apd crashes.

nice thanks for connecting the earlier comment to this one. it was a good reminder about why we do a similar thing for team members, etc. in the Moped advanced search 🙏

johnclary · 2026-07-21T18:23:40Z

+            id: "has_crash_report",
+            column: "record_tables_str",
+            operator: "_ilike",
+            value: "%$crashes$%",


And here's how we find incidents that don't have a crashes record—aka there is no crash report.

An incident cant both have a crash report and not have one, but you can toggle both on as if thats possible. Would it be a big lift to make it so you can only toggle one at a time?

It would be a lift, yeah. FWIW this behavior is consistent with our column visibility toggles as well 🤷‍♂️

okay thats fine then! i figured it would be a big lift

johnclary · 2026-07-21T18:26:22Z

   * Name of the geojson transformer function to use when converting the input table to geojson
   */
-  geojsonTransformerName: "latLon";
+  geojsonTransformerName: "latLon" | "pointFeature";


This lets us consume the geojson Point that comes out of the vz_incident_records_view rather than reconstructing it via lat/lon. Sorta feels like to the right way to have done this from the beginning.

johnclary · 2026-07-21T18:43:09Z

+    path: "incidents",
+    label: "Incidents",
+    icon: FaRoad,
+    allowedRoles: ["editor", "vz-admin"],


Only editors and admins will be able to see this view while we're in this alpha stage of development

When I was testing, I saw that the viewer cannot see the incidents page nav link, but they can navigate to it and to the upload non-CR3s page through a url. I can't remember if role-based routing permissions are implemented or relevant to VZE but wanted to check on that.

oo i think thats a loophole we didnt consider and should fix, i was also able to replicate this.

question though for john -- why is the Incidents list page not allowed for read only?

We decided to keep the incident page obscured from read-only users while it's under development in order to avoid confusing users. It should be harmless if they somehow manage to reach the page, right?

Good to have a gut check on non-CR3s. Read-only users don't have update permissions on the non-cr3 table, so if they did hack the routing the page is harmless.

It's a bit sloppy that we don't redirect users away from restricted pages or show an error message. I'll open a backlog issue for that 🙏

Show an error message when users try to view restricted pages atd-data-tech#29486

mddilley

This looks good to ship to me! I asked a couple questions, and I can turn this into an approval real fast after that. Thanks John! Very nice to see what the shift to incidents looks like in the editor! 🙌

mddilley · 2026-07-22T18:15:45Z

+    'exposed under a common schema for cross-type queries and geo-temporal matching.';
+
+
+CREATE MATERIALIZED VIEW vz_incidents_view AS


👍 and I clocked this migration at about 7 Mississippis to apply on my machine

mddilley · 2026-07-22T18:25:46Z

+        NULLIF(
+            ARRAY_AGG(DISTINCT record_incident_number ORDER BY record_incident_number) 
+            FILTER (WHERE record_incident_number IS NOT NULL),
+            ARRAY[]::text[]
+        ) as incident_numbers,
+        NULLIF(
+            ARRAY_AGG(DISTINCT record_table_name ORDER BY record_table_name) 
+            FILTER (WHERE record_table_name IS NOT NULL),
+            ARRAY[]::text[]
+        ) as record_tables,


are the incident numbers and record tables expected to have corresponding values in their indices? I'm trying to think through how this data is related, and if filtering out null would offset the index in an unexpected way. I might be misunderstanding how the two columns are related!

each row will always have a record_table, but sometimes an incident number can be null. not a concern here, but you are picking up on potential weirdness with the way to way grab address and point_feature using the sorting logic below: it's possible that either one of these are null, in which case we could potentially grab the address from one member record and the point from a different record. it's an extreme edge case but definitely a detail to iron out with the VZ team.

mddilley · 2026-07-22T18:39:18Z

+    path: "incidents",
+    label: "Incidents",
+    icon: FaRoad,
+    allowedRoles: ["editor", "vz-admin"],


When I was testing, I saw that the viewer cannot see the incidents page nav link, but they can navigate to it and to the upload non-CR3s page through a url. I can't remember if role-based routing permissions are implemented or relevant to VZE but wanted to check on that.

mddilley · 2026-07-22T18:44:29Z

+            id: "other",
+            column: "responding_agencies_str",
+            operator: "_nlike",
+            value: "%$apd$%",


nice thanks for connecting the earlier comment to this one. it was a good reminder about why we do a similar thing for team members, etc. in the Moped advanced search 🙏

mddilley · 2026-07-22T18:47:00Z

+    operator: "_ilike",
+    wildcard: true,
+  },
+  searchFields: [{ label: "Address", value: "address" }],


Not related to the code changed in this PR but one thing that was a small speed bump for me when testing the search was being able to know which fields that I could search in the list view. I might have missed something or it might be really obvious to users who are familiar with the app but wanted to mention.

Similarly to Mike, when I followed the test instructions "Search by address, other columns", I tried guessing what other columns to search on (like putting in "ems") and didnt get any results. I couldnt remember if we could search on incident number of not

Sorry for that confusion: i forgot that i didn't enable searching on other columns. I added searching by Incident number as well—I think that will be valuable 🙏

roseeichelmann

Its so awesome to see the incidents coming together in the UI, ive gotta be honest its been kind of hard for me to wrap my heard around incidents and incident matching, but already getting to see it laid out in this list page and map view its helping my visual brain connect the dots.

i also have a few comments/questions as well and i do think the issue mike pointed out about read only still being able to navigate to the page should be addressed if its intended for them not to see this page, but i am ready to approve asap as well!

chiaberry

This is looking great. I am also curious about the permissions around the incident list page. Is that temporary until the Incident details pages are implemented? I'm thinking editors+ are more informed about things in progress...

chiaberry · 2026-07-22T22:27:49Z

+    operator: "_ilike",
+    wildcard: true,
+  },
+  searchFields: [{ label: "Address", value: "address" }],


Similarly to Mike, when I followed the test instructions "Search by address, other columns", I tried guessing what other columns to search on (like putting in "ems") and didnt get any results. I couldnt remember if we could search on incident number of not

chiaberry · 2026-07-22T22:31:03Z

+  properties: GeoJsonProperties;
+}
+
+export default function VzMapPopupContent({


I liked searching for Burnet and then toggling the map and seeing most of the incidents lining up with the street, except one or two. The future incident details page is gonna be great

chiaberry · 2026-07-22T22:33:45Z

+    'exposed under a common schema for cross-type queries and geo-temporal matching.';
+
+
+CREATE MATERIALIZED VIEW vz_incidents_view AS


it took 4 seconds for me

johnclary · 2026-07-23T12:52:58Z

  - name: vz_incident
    using:
      foreign_key_constraint_on: vz_incident_id
+  - name: vz_incidents_view


I just realized that we should name this vz_incidents_list_view to be consistent with our other record views. i'm going to fix this in later because I already have a branch going.

johnclary and others added 19 commits May 28, 2026 14:05

basic working cad list view page

28a25af

add agency to popup

0f9e3b7

add aggregation permissions

8a6e163

Merge branch 'john/27761-cad-incident-links' into john/incident-view

44136d4

adds vz_incidents list view with significant todos wip

f82bbb7

add agency_type_short

fb9aa65

more iterating on incident view, map, etc

6704ae9

rename to incidents

b7a9023

add agency filters

138e844

add missing semicolon;

e282c0b

🤖 Export database views for john/28753-incident-list

c55876a

remove cad page

cc72bfb

add hasura rels to vz_incidents_view

1a9ff05

vz -> incidents

e7613d9

update routes with incidents

71ef723

add type gaurd for points

f4d0869

order unprocessed incidents asc

11239e8

basic incidents page

dc9a77c

replace deprecated type

5a10ab6

johnclary changed the base branch from main to john/incident-etl-redux June 30, 2026 18:00

johnclary added 3 commits June 30, 2026 14:03

merge upstream

dac3be3

migrations wip

ee54c8c

Merge branch 'main' into john/28753-vz-incident-list

78aa578

johnclary changed the base branch from john/incident-etl-redux to main July 10, 2026 19:15

johnclary and others added 3 commits July 10, 2026 17:25

update views

568ab53

update list view with latest changes

057b88d

🤖 Export database views for john/28753-vz-incident-list

66ffd93

johnclary changed the title ~~Create Vision Zero incidents list~~ Create Vision Zero incidents list page Jul 10, 2026

johnclary commented Jul 21, 2026

View reviewed changes

remove dupe op name

43e4de9

johnclary commented Jul 21, 2026

View reviewed changes

johnclary added 3 commits July 21, 2026 14:39

remove todos

a09f025

filter nulls from cols

60e6c3d

fix drop statement in migra

ef29ce8

johnclary commented Jul 21, 2026

View reviewed changes

johnclary and others added 2 commits July 21, 2026 16:32

put materalized in statements

8384dd0

🤖 Export database views for john/28753-vz-incident-list

0b90760

johnclary requested review from Charlie-Henry, chiaberry, frankhereford, mateoclarke, mddilley, roseeichelmann and tillyw July 21, 2026 20:46

remove unused imports

eaf953f

mddilley reviewed Jul 22, 2026

View reviewed changes

roseeichelmann reviewed Jul 22, 2026

View reviewed changes

Comment thread editor/app/incidents/page.tsx Outdated

roseeichelmann approved these changes Jul 22, 2026

View reviewed changes

chiaberry approved these changes Jul 22, 2026

View reviewed changes

johnclary added 4 commits July 23, 2026 08:33

fix text wrapping on beta info text

fc6ca6e

add incident_numbers_str and enable incident number search

96ee8bd

updated record tables col label

b394a1f

add indexes

4cfd1da

johnclary commented Jul 23, 2026

View reviewed changes

Vision Zero View Bot and others added 2 commits July 23, 2026 12:53

🤖 Export database views for john/28753-vz-incident-list

a452c95

add incident_numbers_str

257243b

		'exposed under a common schema for cross-type queries and geo-temporal matching.';


		CREATE MATERIALIZED VIEW vz_incidents_view AS

Uh oh!

Conversation

johnclary commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Associated issues

Testing

Ship list

Uh oh!

netlify Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vzv-staging canceled.

Uh oh!

netlify Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vze-staging canceled.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnclary Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnclary Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mddilley Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnclary Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mddilley left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnclary Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mddilley Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mddilley Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

roseeichelmann left a comment

Choose a reason for hiding this comment

Uh oh!

chiaberry left a comment

johnclary commented Jun 30, 2026 •

edited

Loading

netlify Bot commented Jun 30, 2026 •

edited

Loading

netlify Bot commented Jun 30, 2026 •

edited

Loading

johnclary Jul 23, 2026 •

edited

Loading

johnclary Jul 21, 2026 •

edited

Loading

mddilley Jul 22, 2026 •

edited

Loading

johnclary Jul 23, 2026 •

edited

Loading

johnclary Jul 23, 2026 •

edited

Loading

mddilley Jul 22, 2026 •

edited

Loading

mddilley Jul 22, 2026 •

edited

Loading