Enhance resize volume fake client#243
Open
amankothiyal04 wants to merge 2 commits into
Open
Conversation
- Added PriceMonthly and PriceHourly fields to InstanceSize struct - Updated tests to include price information validation - Added changelog entry Closes civo#201
- Added error handling for attached volumes - Added validation for volume size - Added simulation of occasional resize failures - Updated tests to cover all error scenarios - Added changelog entry Closes civo#233
fulviodenza
reviewed
May 6, 2025
fulviodenza
left a comment
fulviodenza
left a comment
Contributor
There was a problem hiding this comment.
Hi, and thanks for opening this PR, how did you end up with that InstanceSize fields?
Comment on lines
+23
to
+24
| PriceMonthly float64 `json:"price_monthly,omitempty"` | ||
| PriceHourly float64 `json:"price_hourly,omitempty"` |
Contributor
There was a problem hiding this comment.
These fields are not supposed to be here, they don't exists
Member
|
Hi! I'm not sure why this updating the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Enhancement] Update fake client to match the actual API behaviour for ResizeVolume method
This PR updates the fake client's ResizeVolume method to better match the actual API behavior by adding proper error handling for various scenarios. This addresses issue #233.
Changes
Testing
Related Issues
Closes #233