feat(397): expose cidr_v4 and nameservers_v4 in network data source#399
Open
giornetta wants to merge 1 commit into
Open
feat(397): expose cidr_v4 and nameservers_v4 in network data source#399giornetta wants to merge 1 commit into
giornetta wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
cidr_v4andnameservers_v4as computed attributes on thecivo_networkdata source, so the network's CIDR and nameservers can be read without owning the resource. Applies to bothcivo_networkandcivo_vpc_network(same underlying implementation).Also fixes the data source example, which incorrectly showed these attributes as inputs, and regenerates
docs/data-sources/network.md. The acceptance test now asserts both new attributes.Closes #397