fix Parakeet split retry for long recordings#1166
Closed
ferologics wants to merge 1 commit intocjpais:mainfrom
Closed
fix Parakeet split retry for long recordings#1166ferologics wants to merge 1 commit intocjpais:mainfrom
ferologics wants to merge 1 commit intocjpais:mainfrom
Conversation
b936310 to
9f1f11f
Compare
9f1f11f to
fe1be85
Compare
fe1be85 to
2d38f81
Compare
Owner
|
Look at my PR for chunking |
Contributor
Author
|
I tested #1173 's chunked Parakeet path against the original failing long recording ( Given that, I think #1173 is the better direction to land:
So I'm closing this in favor of #1173 rather than trying to merge two competing fixes for the same issue. The fallback/recovery idea from this PR may still be worth revisiting later, ideally lower in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Long Parakeet recordings can still fail with a recoverable inference error like:
That currently bubbles up as a hard failure instead of retrying on smaller chunks.
Validation
cd src-tauri && cargo checkcd src-tauri && cargo test~/Library/Application Support/com.pais.handy/recordings/handy-1774637386.wavFollow-up notes
transcribe-rs