fix(linux): use DOM keyboard events for shortcut recording to avoid rdev::grab() conflict with HotkeyManager#1258
Open
possiblyneal wants to merge 1 commit intocjpais:mainfrom
Open
Conversation
…dev::grab() conflict with HotkeyManager Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
Is it possible to fix this directly in handy-keys? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux,
rdev::grab()(used by the handy-keys backend recording loop) conflicts with theHotkeyManager— grabbing exclusive access to the keyboard causes periodic system freezes and no key events being captured during shortcut recording.This PR fixes the issue by detecting Linux at runtime and falling back to DOM
keydown/keyupevents for shortcut recording instead of the backendhandy-keys-eventstream. The backendstartHandyKeysRecordingcall is still made (so the backend can disable the active hotkey during recording), but key capture is handled entirely in the frontend on Linux.Changes
src/components/settings/HandyKeysShortcutInput.tsxuseEffectthat activates only on Linux (osType === "linux")KeyboardEventmodifiers +getKeyName()keyup(same flow as the non-Linux path)handy-keys-eventlistener effect is still present but does not receive events on Linux since the backend skips the grabsrc-tauri/src/shortcut/handy_keys.rsKeyboardListener::new()in#[cfg(not(target_os = "linux"))]so the secondrdev::grab()call is never made on Linux, eliminating the periodic 2-second freeze