fix: copy table keys into merged pool in toml_merge#37
Merged
Conversation
tab_emplace stores key pointers without copying, so datum_copy and datum_merge aliased the merged tree's keys into the source pools. Freeing an input after merge dangled those keys -> use-after-free. Copy each key into the merged pool, like string values already are. Pool size (r1->top + r2->top) stays a valid upper bound. Adds test_keys_outlive_inputs: aborts under ASan without the fix.
dutow
force-pushed
the
fix/merge-key-dangling-pointer
branch
from
2e66a65 to
4181f98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tab_emplace stores key pointers without copying, so datum_copy and datum_merge aliased the merged tree's keys into the source pools. Freeing an input after merge dangled those keys -> use-after-free.
Copy each key into the merged pool, like string values already are. Pool size (r1->top + r2->top) stays a valid upper bound.
Adds test_keys_outlive_inputs: aborts under ASan without the fix.