defroutes w/ validations nil param fix#86
Open
RyanBertrand wants to merge 1 commit intoclj-commons:masterfrom
Open
defroutes w/ validations nil param fix#86RyanBertrand wants to merge 1 commit intoclj-commons:masterfrom
RyanBertrand wants to merge 1 commit intoclj-commons:masterfrom
Conversation
It seems that calling re-matches when the value pulled from params is nil throws an error.
Contributor
|
Any reason you're not using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting errors while using
defroutewith validations.My vector route looked like:
The error printed to the JS console was:
It seems that calling re-matches when the value pulled from params is nil throws an error in
invalid-paramsfn.This pr adds an additional check to see if the param value is non-nil before trying to validate it via regex. If it is nil, then it is essentially invalid as it doesn't match the route.
Thanks for the great library!