Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the UAA client administration surface to support configuring client JWT trust (“clientjwt”) by adding JWKS-related fields to the client model and introducing a new API method + tests for the PUT /oauth/clients/{id}/clientjwt endpoint.
Changes:
- Add
jwks_uriandjwksfields toClient. - Add
ChangeClientJWTplus supporting request/mode types for theclientjwtendpoint. - Add unit tests validating
ChangeClientJWTrequest method/path/body and error behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
clients.go |
Adds JWKS fields to the client model and implements the ChangeClientJWT API call. |
clients_test.go |
Adds tests for the new ChangeClientJWT method covering multiple request shapes and error handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
duanemay
approved these changes
Jul 1, 2026
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.