feat: fix tflint findings and typos, add support for force_update_version and control_plane_scaling_config

[RoseSecurity]

what

• Fix random typos
• Fix random TFLint findings
• Add support for the force_update_version and control_plane_scaling_config parameters

why

• Add enhancements and new capabilities to the module
• Address TFLint findings and clean up typos

references

• Terraform Docs

[RoseSecurity]

/terratest

[coderabbitai]

Need an answer fast? Review this PR in Change Stack to ask focused questions about the PR or a changed range.

📝 Walkthrough

Walkthrough

This PR adds two new input variables to the EKS cluster Terraform module—force_update_version (boolean) and control_plane_scaling_config (object)—and configures the primary cluster resource to use them. Documentation typos are fixed and deprecated variables from an obsolete example are removed.

Changes

Control plane features and maintenance

Layer / File(s)	Summary
New EKS control plane input variables variables.tf	Added force_update_version boolean input to control EKS upgrade behavior and control_plane_scaling_config object to configure control plane scaling tier. Normalized leading whitespace in deletion_protection_enabled description.
EKS cluster resource configuration updates main.tf	Wired new input variables into aws_eks_cluster.default: added force_update_version argument and conditional dynamic "control_plane_scaling_config" block that applies tier setting when the input is provided.
Documentation and obsolete example cleanup docs/migration-v3-v4.md, examples/obsolete-version2/variables.tf	Fixed Debian spelling error in migration docs. Removed deprecated variables (map_additional_aws_accounts, map_additional_iam_roles, map_additional_iam_users) from obsolete example module and corrected description typo (acces → access).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• cloudposse/terraform-aws-eks-cluster#260: Both PRs modify the deletion_protection_enabled variable description in variables.tf, with this PR adjusting whitespace while the related PR adds and implements the variable in the cluster resource.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description is well-related to the changeset, covering all major aspects: typo fixes, TFLint findings, and new parameter support with clear references.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately summarizes all three main aspects of the changeset: typo fixes, tflint findings, and two new feature additions (force_update_version and control_plane_scaling_config).

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch typo-fixes-and-scaling-configs

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@variables.tf`:
- Around line 235-241: Add a validation block to the variable
"control_plane_scaling_config" to enforce allowed values for its "tier"
attribute so invalid tiers fail at plan time; specifically, inside the variable
definition for control_plane_scaling_config add a validation that checks either
the whole object is null or that lookup(var.control_plane_scaling_config,
"tier", "standard") (or equivalent) is one of the allowed strings ("standard",
"tier-xl", "tier-2xl", "tier-4xl", "tier-8xl") and provide a clear error_message
listing those valid options to guide users when they provide an unsupported
tier.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8e4aa154-88a2-4a52-b578-81e6365d3cdf

📥 Commits

Reviewing files that changed from the base of the PR and between e31a2ed and 0f76f25.

📒 Files selected for processing (4)

• docs/migration-v3-v4.md
• examples/obsolete-version2/variables.tf
• main.tf
• variables.tf