feat: allow sg referencing support#64
Merged
Igor Rodionov (goruha) merged 14 commits intoAug 11, 2025
Merged
Conversation
added 2 commits
August 8, 2025 15:45
Bruce (brucex)
requested review from
Joe Niland (joe-niland) and
RB (nitrocode)
yangci (oycyc)
previously approved these changes
Aug 8, 2025
yangci (oycyc)
left a comment
yangci (oycyc)
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the addition -- matches with the docs as well: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ec2_transit_gateway#security_group_referencing_support-1
|
/terratest |
yangci (oycyc)
added
minor
yangci (oycyc)
changed the title
|
Tests failing (due to no fault of the PR code)... Posted in Slack |
Member
|
/terratest |
Igor Rodionov (goruha)
requested changes
Aug 11, 2025
Igor Rodionov (goruha)
left a comment
Igor Rodionov (goruha)
left a comment
Member
There was a problem hiding this comment.
Add validation please or use bool type for the variable
Bruce (brucex)
requested review from
Igor Rodionov (goruha) and
yangci (oycyc)
Igor Rodionov (goruha)
previously approved these changes
Aug 11, 2025
Contributor
Author
|
/terratest |
added 2 commits
August 11, 2025 12:01
Igor Rodionov (goruha)
approved these changes
Aug 11, 2025
Member
|
/terratest |
Contributor
|
These changes were released in v0.12.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
why
references