Fix STDIO transport crashing on incoming messages#243
Open
n0vdd wants to merge 1 commit intocloudwalk:mainfrom
Open
Fix STDIO transport crashing on incoming messages#243n0vdd wants to merge 1 commit intocloudwalk:mainfrom
n0vdd wants to merge 1 commit intocloudwalk:mainfrom
Conversation
Message.decode/1 returns {:ok, messages} where messages is a list,
but the STDIO transport passed this list directly to process_message/2
which expects a single map. This caused a BadMapError on every incoming
message.
The StreamableHTTP transport already handles this correctly by
pattern-matching {:ok, [message]} in handle_post/2. This fix iterates
over the decoded messages list, matching the expected behavior.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Message.decode/1returns{:ok, messages}wheremessagesis always a list, but the STDIO transport passed this list directly toprocess_message/2which expects a single mapBadMapErroron every incoming message via the STDIO transport{:ok, [message]}inhandle_post/2Enum.each/2Test plan
BadMapErrorby sendinginitialize,notifications/initialized, andtools/listmessages over stdio🤖 Generated with Claude Code