select bins to plot in PostFitShapesFromWorkspace#336
Open
fabio-mon wants to merge 2 commits intocms-analysis:mainfrom
Open
select bins to plot in PostFitShapesFromWorkspace#336fabio-mon wants to merge 2 commits intocms-analysis:mainfrom
fabio-mon wants to merge 2 commits intocms-analysis:mainfrom
Conversation
Collaborator
|
Thanks, it looks good to me! |
Author
|
Hi now it might look less good as I implemented a wrapper within combineTool.py to submit PostFitShapesFromWorkspace splitting by bin. I have two doubts:
|
Collaborator
|
Hi @fabio-mon, as you can see we moved combineTool.py to the Combine repository here. I would say that we could move this part to Combine, checking if combineHarvester is installed, and advising to do that if not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://cms-talk.web.cern.ch/t/accelerating-postfits-fitdiagnostics/15934/10