Skip to content

Fix split delimiter for float nuisances #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
secholak wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix split delimiter for float nuisances #1247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Combine.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@
if (floatNuisances_=="all") {
toFloat.add(*nuisances);
} else {
std::vector<std::string> nuisToFloat = Utils::split(floatNuisances_, "n");
std::vector<std::string> nuisToFloat = Utils::split(floatNuisances_, ",");

Check warning on line 637 in src/Combine.cc

View check run for this annotation

Codecov / codecov/patch

src/Combine.cc#L637 

Added line #L637 was not covered by tests
Comment on lines 634 to +637
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Run clang-format on the touched block.

The comma delimiter fix on Line 637 looks correct and matches the freeze-parameter parser, but CI is failing with git-clang-format differences around Line 634.

git clang-format HEAD~ -- src/
🧰 Tools
🪛 GitHub Actions: clang-format

[error] 634-634: CI failed due to git-clang-format formatting differences in this file. The pipeline suggests running locally: git-clang-format HEAD~ (command: git clang-format ... -- src/).

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@src/Combine.cc` around lines 634 - 637, The CI failure is due to formatting
changes around the block handling floatNuisances_ in Combine.cc; run
clang-format (or git-clang-format HEAD~ -- src/) and reformat the block
containing the floatNuisances_ check/branch (the if (floatNuisances_=="all") {
toFloat.add(*nuisances); } else { std::vector<std::string> nuisToFloat =
Utils::split(floatNuisances_, ","); }) so whitespace/brace placement matches
project style, then stage the reformatted changes and push.

for (int k=0; k<(int)nuisToFloat.size(); k++) {
if (nuisToFloat[k]=="") continue;
else if(nuisToFloat[k]=="all") {
Expand Down
Loading