Avoid problems with FastVerticalInterpHistPdf2Base initialization#952
Merged
anigamova merged 1 commit intocms-analysis:mainfrom Jun 7, 2024
Merged
Conversation
The `_sentry` is already filled when calling `evaluate()`, so no need to do that in the copy constructor. Doing so can actually leading to redundant calls to `_sentry.addVars(_coefList)`, resulting in the problem reported here: cms-analysis#940 (comment) ``` [#0] ERROR:InputArguments -- RooArgSet::checkForDup: ERROR argument with name CMS_vhbb_stats_TT_ZmmLoose7TeV is already in this set ```
guitargeek
force-pushed
the
FastVerticalInterpHistPdf2Base_ub
branch
from
6fb45fe to
6d80723
Compare
guitargeek
changed the title
FastVerticalInterpHistPdf2Base initializationFastVerticalInterpHistPdf2Base initialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_sentryis already filled when callingevaluate(), so no need to do that in the copy constructor:https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/blob/main/src/VerticalInterpHistPdf.cc#L895
Doing so can actually leading to redundant calls to
_sentry.addVars(_coefList), resulting in the problem reported here:#940 (comment)
FYI @kcormi