L1S(Nano): updates for 2026 data-taking (CaloTowers, Scenario) [16_0_X]#50511
Merged
cmsbuild merged 8 commits intocms-sw:CMSSW_16_0_Xfrom Mar 27, 2026
Merged
Conversation
Contributor
|
A new Pull Request was created by @missirol for CMSSW_16_0_X. It involves the following packages:
@AdrianoDee, @DickyChant, @antoniovagnerini, @battibass, @cmsbuild, @davidlange6, @emeschi, @fabiocos, @ftenchini, @ftorrresd, @mandrenguyen, @miquork, @smorovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
|
cms-bot internal usage |
Contributor
|
enable nano |
Contributor
|
please test |
Contributor
Author
|
The merge conflict in this PR is due to the integration of #50497. I'll have to rebase this PR on one of the next 16_0_X IBs. |
Contributor
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
Nano size comparison Summary:
NANO Comparison SummarySummary:
|
cmsbuild
added
operations-approved
tests-approved
and removed
operations-pending
tests-started
labels
Contributor
|
+daq |
Contributor
|
pinging @cms-sw/xpog-l2 and @cms-sw/pdmv-l2 for sign off please |
…=True This changes the initialisation of the vector "selbxOffsets", which is used in case the parameter "skipNonExistingSrc" is set to True. Without this change, that vector is empty, and this leads to a segmentation fault at https://github.com/cms-sw/cmssw/blob/edd2f62bfb3fe43fdc5609ce38b82169e80251fb/DataFormats/NanoAOD/interface/OrbitFlatTable.h#L27
Updates to add CaloTowers' information to the output of "L1ScoutingNano" for 2026 workflows. This is done by adding a modifier named "run3_l1scouting_2026", and including it in the Era "Run3_2026". Various updates are made to custom_l1scoutingrun3_cff, mainly - using a dedicated Sequence (rather than overriding the regular NANO sequence), and - making the customisation of the relevant output module(s) more robust (covering both the NANOEDMAOD and NANOAOD data tiers, and not relying solely on the label of the output module). Co-Authored-By: Rocco Ardino <rocco.ardino@cern.ch>
This change adds wfs to test on real data the NANOAOD flavours "L1Scout" and "L1ScoutSelect" for the Eras "Run3_2025" and "Run3_2026".
…a to EventContent_cff The EventContents (incl. compression settings) of Run-3 L1-Scouting data for the NANO(EDM)AOD data tiers are now defined in a dedicated file [1], and the latter file is imported by [2], following what is done for other EventContents used in "central production". The implementation of the L1-Scouting NANOAOD flavours is updated accordingly (removing explicit "keep/drop statements" from the relevant customisation functions). [1] PhysicsTools/NanoAOD/python/L1SCOUTNanoAODEDMEventContent_cff.py [2] Configuration/EventContent/python/EventContent_cff.py
Contributor
|
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
Nano size comparison Summary:
NANO Comparison SummarySummary:
|
cmsbuild
added
operations-approved
tests-approved
and removed
operations-pending
tests-started
labels
Contributor
Author
|
All looks okay in the outputs of these latest PR tests (suggesting that the test error in #50510 (comment) is unrelated to these changes). |
Contributor
|
+daq |
Contributor
|
urgent |
Contributor
|
+1 |
cmsbuild
added
fully-signed
xpog-approved
and removed
pending-signatures
xpog-pending
labels
Contributor
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_16_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
Will merge this after checking the results of the master IB. |
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #50510
PR description:
From the description of #50510:
The original version of this PR was in #50375, it included only the first 3 points of the list above. It was not reviewed timely, and it ended up being replaced by this PR.
PR validation:
None beyond the checks made for #50510.
If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
#50510
Updates to run the NanoAOD step on L1-Scouting data at T0 during 2026 data-taking.