NanoAOD: remove saveTriggerResults parameter from NanoAOD*OutputModule (revert #50057)#50797
Open
missirol wants to merge 2 commits intocms-sw:masterfrom
Open
NanoAOD: remove saveTriggerResults parameter from NanoAOD*OutputModule (revert #50057)#50797missirol wants to merge 2 commits intocms-sw:masterfrom
saveTriggerResults parameter from NanoAOD*OutputModule (revert #50057)#50797missirol wants to merge 2 commits intocms-sw:masterfrom
Conversation
Contributor
|
cms-bot internal usage |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50797/49108
|
Contributor
|
A new Pull Request was created by @missirol for master. It involves the following packages:
@battibass, @cmsbuild, @ftorrresd can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
|
enable nano |
Contributor
|
please test |
Contributor
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
Nano size comparison Summary:
NANO Comparison SummarySummary:
|
Contributor
Author
|
No warnings/errors, and no DQM differences (modulo #47071), in the outputs of the tests, as expected. |
Contributor
|
+1 |
cmsbuild
added
fully-signed
xpog-approved
and removed
pending-signatures
xpog-pending
labels
Contributor
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
This PR reverts #50057 (which was integrated in
CMSSW_16_1_0_pre3).For what I understand (thanks to #50720), the parameter
saveTriggerResultsintroduced in #50057 is redundant, because settingsaveTriggerResultstoFalsein instances ofNanoAODOutputModuleis equivalent to "dropping" theedm::TriggerResultsproducts from those OutputModules.Merely technical, no changes expected in the outputs of PR tests.
Apologies for the back and forth!
PR validation:
Took
CMSSW_16_1_0_pre4(without this PR) and the step2 config of wf2500.3001(NanoAOD step), modified the latter config to useprocess.NANOAODSIMoutput.saveTriggerResults = cms.untracked.bool(False)in one case, andprocess.NANOAODSIMoutput.outputCommands += ["drop edmTriggerResults_*_*_*"]in another case,and verified that the NanoAOD outputs of (a) and (b) have the same branches (and no
edm::TriggerResults-related branches are present in the output files).If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
No backports are necessary (if XPOG requests it, I can backport this PR to
16_1_Xin order to remove this redundant parameter in that cycle).