slightly less undefined behavior in Vector3D and Vector4D implementation#6
Open
axelfeldmann wants to merge 1 commit intocmu462:masterfrom
Open
slightly less undefined behavior in Vector3D and Vector4D implementation#6axelfeldmann wants to merge 1 commit intocmu462:masterfrom
axelfeldmann wants to merge 1 commit intocmu462:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vector3D and Vector4D depend on undefined (and brittle) behavior in their indexing overloads. This PR is still technically undefined behavior according to the C++ standard, but this form of type punning is defined and supported by all major C++ compilers (I know for a fact about gcc, clang, and mscv).