NexusJS: Prevent cache poisoning on updated assets#177
Open
sdumetz wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an asset is updated, the current indexedDB cache doesn't pick up the change as it's keyed only by
url. It results in potentially mangled textures or plain errors.This fix tries to ensure cache freshness before use.
The second commit makes it even safer, using the
ETagheader if present. Otherwise it relies on mesh statistics that are very likely, but not guaranteed, to change when it is updated.An additional fix addresses
let request = transaction.objectStore('tex').get(node.id);, which could collide if a texture was used by more than one node.