Open
Conversation
jayvdb
requested changes
Mar 30, 2018
utils/filters.py
Outdated
| def filter_ignored_users(self, msg, cmd, args, dry_run): | ||
| if msg.frm.nick in self.bot_config.IGNORE_USERNAMES: | ||
| def filter_users(self, msg, cmd, args, dry_run): | ||
| name = msg.frm.fullname if BACKEND == 'Zulip' else msg.frm.nick |
Member
There was a problem hiding this comment.
this PR isnt about Zulip. Please remove. This isnt how we will do Zulip anyway; the patches for Zulip are public.
Member
Author
|
@jayvdb Updated |
Member
|
@gitmate-bot rebase |
|
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
|
Automated rebase with GitMate.io was successful! 🎉 |
Contributor
|
Up for grabs, or is anyone working on it @jayvdb. |
Member
|
@gitmate-bot rebase |
|
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
Member
|
@gitmate-bot rebase |
|
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
|
Automated rebase with GitMate.io was successful! 🎉 |
jayvdb
requested changes
Aug 13, 2018
utils/filters.py
Outdated
| def filter_users(self, msg, cmd, args, dry_run): | ||
| if msg.frm.nick in self.bot_config.IGNORE_USERNAMES: | ||
| return None, None, None | ||
| if msg.frm.nick not in self.bot_config.REQUIRED_USERS \ |
utils/filters.py
Outdated
| if msg.frm.nick in self.bot_config.IGNORE_USERNAMES: | ||
| return None, None, None | ||
| if msg.frm.nick not in self.bot_config.REQUIRED_USERS \ | ||
| and self.bot_config.RESP_ONLY_REQ_USER: |
Member
There was a problem hiding this comment.
this must be indented four more spaces to avoid confusion with the statements inside the if block
Travis tests have failedHey @Vamshi99, 1st Buildcoala --non-interactive -V |
Vamshi99
force-pushed
the
filter
branch
2 times, most recently
from
c9d6cf1 to
f0c514d
Compare
If RESP_ONLY_REQ_USERS configuration is true, then stop responding to users other than those in the REQUIRED_USERS list in config. Closes coala#515
Vamshi99
commented
Aug 21, 2018
| class FiltersTest(IsolatedTestCase): | ||
|
|
||
| def test_filter_users(self): | ||
| self.bot_config.RESP_ONLY_REQ_USERS = False |
Member
There was a problem hiding this comment.
@Vamshi99 IsolatedTestCase loads all the plugins present in plugins/ directory except LabHub, hence this filter is not loaded by the bot since it is in utils/ dir.
Travis tests have failedHey @Vamshi99, 1st Buildpython -m pytest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If RESP_ONLY_REQ_USERS configuration is true,
then stop responding to users other than those
in the REQUIRED_USERS list in config.
Closes #515
Reviewers Checklist
botcmdandre_botcmddecorators.