labhub.py: Alert when @mention is not in room#630
Open
abhishalya wants to merge 1 commit intocoala:masterfrom
Open
labhub.py: Alert when @mention is not in room#630abhishalya wants to merge 1 commit intocoala:masterfrom
abhishalya wants to merge 1 commit intocoala:masterfrom
Conversation
Member
Author
|
Obviously the tests will fail as I have removed the |
Member
Author
|
@jayvdb Can you please check the warning message so that I can make changes to the tests? |
Member
No. Fixing/adding unit tests are an integral part of changing code. |
The fix introduces removal of is_room_member function and instead uses callback_message to warn whenever `@mention` is not in room. Closes coala#603
Member
Author
|
Blocked until errbotio/err-backend-gitter#38 is solved. |
abhishalya
commented
Mar 8, 2019
| self.hello_world_users.add(user) | ||
|
|
||
| mentioned = [] | ||
| room_members = msg.frm.room.occupants |
Member
Author
There was a problem hiding this comment.
We need to fetch the people once reducing the number of API calls and eventually update the list as soon as there are new people in the room, will improve this later on once we've fixed backend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix introduces removal of is_room_member
function and instead uses callback_message to warn
whenever
@mentionis not in room.Closes #603
Reviewers Checklist
botcmdandre_botcmddecorators.