tilemap: Fixed calculation of tileset rows/columns#3537
Open
bjorn wants to merge 1 commit intococos2d:developfrom
Open
tilemap: Fixed calculation of tileset rows/columns#3537bjorn wants to merge 1 commit intococos2d:developfrom
bjorn wants to merge 1 commit intococos2d:developfrom
Conversation
The margin should only be subtracted once, since it’s irrelevant whether the margin exists also at the bottom or the right side of the image. With this change it matches the behavior of Tiled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The margin should only be subtracted once, since it’s irrelevant whether the margin exists also at the bottom or the right side of the image.
With this change it matches the behavior of Tiled.
Note that I didn't have time to test this change, but I think it's straight-forward enough.