refactor(worker): Inject repository service into ReportService and optimize commit query#788
Merged
thomasrockhu-codecov merged 4 commits intomainfrom Mar 30, 2026
Conversation
…timize commit query
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #788 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 1305 1305
Lines 47981 47985 +4
Branches 1636 1636
=======================================
+ Hits 44263 44267 +4
Misses 3407 3407
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-authored-by: Tom Hu <88201630+thomasrockhu-codecov@users.noreply.github.com>
thomasrockhu-codecov
approved these changes
Mar 29, 2026
drazisil-codecov
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WORKER-VHG. The issue was that: Repeated
GithubAppInstallationqueries due to lazy-loaded relationships and uncachedget_repo_provider_servicecalls.ReportServiceto accept an optionalTorngitBaseAdapterinstance asrepository_servicein its constructor.ReportService'sget_existing_report_for_carryforwardmethod to utilize the injectedrepository_serviceif provided, falling back toget_repo_provider_serviceotherwise.preprocess_upload_taskto eagerly loadRepository,Owner, andGithubAppInstallationdata when fetching aCommitobject, reducing N+1 queries.repository_serviceto theReportServiceconstructor withinpreprocess_upload_task.This fix was generated by Seer in Sentry, triggered by Tom Hu. 👁️ Run ID: 12511267
Not quite right? Click here to continue debugging with Seer.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Note
Medium Risk
Touches the report carryforward initialization path and how provider diffs are fetched, so regressions could affect carryforward line shifting. Also changes ORM loading behavior in the preprocess task, which is low-risk but could surface relationship/loading assumptions.
Overview
Reduces repeated git-provider and DB lookups during preprocess by injecting a pre-created
TorngitBaseAdapterintoReportServiceand reusing it when shifting carryforward reports (falling back toget_repo_provider_serviceonly if not provided).Optimizes
preprocess_uploadby eager-loadingCommit.repository -> Repository.author -> Owner.github_app_installationsviajoinedload, then passing the fetchedrepository_serviceintoReportServiceto avoid N+1/lazy-load queries during report initialization.Written by Cursor Bugbot for commit 06d6205. This will update automatically on new commits. Configure here.