Skip to content

feat(worker): Pass commit timestamp to test analytics status check#792

Merged
drazisil-codecov merged 1 commit intomainfrom
seer/feat/ta-timestamp-filter-cW5YSW
Apr 10, 2026
Merged

feat(worker): Pass commit timestamp to test analytics status check#792
drazisil-codecov merged 1 commit intomainfrom
seer/feat/ta-timestamp-filter-cW5YSW

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry bot commented Apr 10, 2026

Fixes WORKER-VPM. The issue was that: get_test_status calls get_pr_comment_agg without lower_bound_timestamp, forcing unoptimized TimescaleDB query.

  • Modified get_test_status to accept an optional lower_bound_timestamp parameter.
  • Passed the new lower_bound_timestamp to get_pr_comment_agg for more precise test analytics aggregation.
  • Updated notify_commit_comparison task to provide the commit's timestamp when checking test status.

This fix was generated by Seer in Sentry, triggered by Tom Hu. 👁️ Run ID: 12643372

Not quite right? Click here to continue debugging with Seer.


Note

Low Risk
Low risk: a small signature change to get_test_status and its call site to add an optional timestamp filter, primarily impacting the Test Analytics aggregation query path.

Overview
Updates the worker’s Test Analytics status check to accept an optional lower_bound_timestamp and forwards it to get_pr_comment_agg to constrain the underlying aggregation query.

The notifications task now passes the commit’s timestamp when calling get_test_status, aiming to reduce query cost/noise while preserving existing pass/fail behavior.

Reviewed by Cursor Bugbot for commit a1073fa. Bugbot is set up for automated code reviews on this repo. Configure here.

@sentry
Copy link
Copy Markdown
Contributor Author

sentry bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (d005280) to head (a1073fa).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #792   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files        1305     1305           
  Lines       47994    47995    +1     
  Branches     1636     1636           
=======================================
+ Hits        44276    44277    +1     
  Misses       3407     3407           
  Partials      311      311           
Flag Coverage Δ
workerintegration 58.58% <100.00%> (+<0.01%) ⬆️
workerunit 90.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@drazisil-codecov drazisil-codecov added this pull request to the merge queue Apr 10, 2026
Merged via the queue into main with commit 8c332b1 Apr 10, 2026
40 checks passed
@drazisil-codecov drazisil-codecov deleted the seer/feat/ta-timestamp-filter-cW5YSW branch April 10, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants