feat(worker): Pass commit timestamp to test analytics status check#792
Merged
drazisil-codecov merged 1 commit intomainfrom Apr 10, 2026
Merged
Conversation
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 1305 1305
Lines 47994 47995 +1
Branches 1636 1636
=======================================
+ Hits 44276 44277 +1
Misses 3407 3407
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
thomasrockhu-codecov
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WORKER-VPM. The issue was that:
get_test_statuscallsget_pr_comment_aggwithoutlower_bound_timestamp, forcing unoptimized TimescaleDB query.get_test_statusto accept an optionallower_bound_timestampparameter.lower_bound_timestamptoget_pr_comment_aggfor more precise test analytics aggregation.notify_commit_comparisontask to provide the commit's timestamp when checking test status.This fix was generated by Seer in Sentry, triggered by Tom Hu. 👁️ Run ID: 12643372
Not quite right? Click here to continue debugging with Seer.
Note
Low Risk
Low risk: a small signature change to
get_test_statusand its call site to add an optional timestamp filter, primarily impacting the Test Analytics aggregation query path.Overview
Updates the worker’s Test Analytics status check to accept an optional
lower_bound_timestampand forwards it toget_pr_comment_aggto constrain the underlying aggregation query.The notifications task now passes the commit’s
timestampwhen callingget_test_status, aiming to reduce query cost/noise while preserving existing pass/fail behavior.Reviewed by Cursor Bugbot for commit a1073fa. Bugbot is set up for automated code reviews on this repo. Configure here.