Conversation
The RescueGroups v5 API's documented filter operations are equal, notequal, contains, blank, etc. -- there is no "equals". An unrecognized operation is silently ignored, so the species filter never applied and multi-species searches could return zero results (the #124 symptom the docstring warns about). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QdBGKrsY7nJdXXYDKNq6o5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
You were right — the RescueGroups v5 API's documented filter operations are
equal,notequal,contains,notcontains,blank,notblank,lessthan,greaterthan, etc. There is noequals.The species filter in
_build_species_filtersused"operation": "equals". An unrecognized operation is silently ignored by the API, so thespecies.singularfilter never actually applied. This is very likely the real cause of the zero-results behavior the docstring warns about (#124).Change
adoption_sources/rescue_groups.py:"equals"→"equal"in the species filter, plus a docstring note.tests/test_rescue_groups.py: updated expected payloads.Verification
pytest— 134 passed, 1 skipped (live test; no API key in this environment).CUTEPETSBOSTON_RESCUEGROUPS_API_KEYset:pytest tests/test_rescue_groups_live.py🤖 Generated with Claude Code