Added D.C., switched to full state names, and changed Prettier language to node - #780
Open
AdamFinkle wants to merge 1 commit into
Open
AdamFinkle wants to merge 1 commit into
AdamFinkle wants to merge 1 commit into
Conversation
Sarang-Patel
reviewed
Sep 9, 2026
Collaborator
There was a problem hiding this comment.
Hi, This is good.
But the original issue wanted this implemented on the sign up page. But this change on cases is also needed so, keep the change on cases page and, if we can get this on sign up as well, it will be great.
Sign up page has its own dropdown, it can be replaced with this custom one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #768
The issue commit
This pull request adds the District of Columbia to the list of available states (though it is not technically a state) and changes the labels of the states in the dropdown to their full names rather than their abbreviations. I have not added Puerto Rico, though it could be added in principle, because the issue did not mention it.
The Prettier commit
While addressing this issue, I encountered trouble running Prettier, but, per LLM suggestion, I changed the language of the hook from
systemtonode, which fixed the problem. Why did this problem occur at all to begin with? According to the LLM, when Node is installed via tools like NVM, the Node that Prettier needs is hidden rather than being on the $PATH, which is where Prettier looks when the language is set tosystem. I don't know why this problem wasn't encountered by someone else earlier, but I encountered it. The LLM continued that the fix is to set the language tonode; per the pre-commit documentation (https://pre-commit.com/)The LLM concluded that this change enables Prettier to find node, even though we install it with NVM.