WIP: Automatically collapse info section on user interaction - #309
Draft
azheng1991 wants to merge 2 commits into
Draft
azheng1991 wants to merge 2 commits into
azheng1991 wants to merge 2 commits into
Conversation
Collaborator
Author
|
Didn't see a way to leave comments on each individual file, so I'm leaving them in this format:
As far as testing the changes, when I tried running npm start I got an error saying that LandingBlurbContainer didn't exist in the file structure of import { LandingBlurbContainer } from '../LandingBlurb', even though I definitely saw a LandingBlurbContainer.tsx file in that folder |
Collaborator
|
awesome. Thanks a bunch!
…On Fri, Feb 19, 2021 at 1:47 PM Allan Zheng ***@***.***> wrote:
Didn't see a way to leave comments on each individual file, so I'm leaving
them in this format:
1. for the change on frontend/.env, this was done so that the app
worked locally on my machine as I had previously been receiving a noapi
error
2. frontend/src/ui/LandingBlurb/LandingBlurb.stories.tsx: this change
was done in order to make landing blurb it's own folder directory because
the landingblurb component within it needed to have a container so that we
could change it's behavior upon selection of the occupation.
3. frontend/src/ui/LandingBlurb/LandingBlurb.tsx: this change was made
so that the landingblurb could be clicked to expand the title text (to keep
the original behavior of being able to expand and collapse that blurb).
4. frontend/src/ui/LandingBlurb/LandingBlurbContainer.tsx: this was
the meat of the PR, the useEffect function in there was what was being used
to change the behavior of the landingblurb container once the user had
selected the occupation
As far as testing the changes, when I tried running npm start I got an
error saying that LandingBlurbContainer didn't exist in the file structure
of import { LandingBlurbContainer } from '../LandingBlurb', even though I
definitely saw a LandingBlurbContainer.tsx file in that folder
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#309 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEMD2CR7QDHMEJZCWMBHWFLS72W3LANCNFSM4X2TA4ZQ>
.
|
jedpittman
requested changes
Feb 19, 2021
jedpittman
left a comment
Collaborator
There was a problem hiding this comment.
There's more to do here to get this to a usable state. I'm reaching out via slack.
alexjball
marked this pull request as draft
March 27, 2021 17:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.