Generate RPG data structure from result metadata#368
Generate RPG data structure from result metadata#368worksofliam merged 14 commits intocodefori:mainfrom
Conversation
worksofliam
left a comment
There was a problem hiding this comment.
I left a comment about moving logic to another function.
I don't want the logic to generate the content in this function really. We should move it elsewhere so we can write test cases for it.
Please make this change and then lmk when to look again.
|
@worksofliam : Where do you want the tests? A new testsuite? Please continue to comment if you want me to change something else :) I will continue working on this tomorrow |
|
@janfh For my own sake of mind, I have had to move this to fix day 2 (Wednesday 23rd) and this will be the first PR I look at then. I may get to it over the weekend if I find a moment. Thanks for your work here! Also, let's chat on chat.ibmioss.org sometime. |
|
@janfh Is there any reason you aren't using this switch (statementDetail.qualifier) { |
@worksofliam : I think it was to avoid changing that runSql on 405. But I can change this if you like. I guess there is no reason why we can't always use the runSqlVerbose? |
|
@janfh i guess Going to do some final tests in the morning on this one and it should be good to go. |
# Conflicts: # package-lock.json
|
@janfh Last thing now is to fix the conflict and we should be good to go. |
|
Done :) |
Feature to generate RPG data structure from column metadata.
Added statement qualifier "rpg". E.g:
generates: