Result view - include label/name in tooltip#383
Merged
worksofliam merged 8 commits intocodefori:mainfrom Apr 28, 2025
Merged
Conversation
# Conflicts: # src/views/results/html.ts
# Conflicts: # src/connection/manager.ts
Member
@janfh I tried this today but I can't seem to get the label to show. What am I missing? LABEL ON COLUMN SNDBX87.DEPARTMENT (deptno is 'department number');
SELECT * FROM SNDBX87.DEPARTMENT as a; |
Contributor
Author
|
@worksofliam : Can you please verify that extended metadata is enabled for the connection? |
Member
|
@janfh I can confirm it is. |
Member
|
@janfh I just noticed there is no change to I see it come through when I set it manually:
|
Contributor
Author
|
@worksofliam : Looks like I managed to revert extended metadata when merging from master. Appears to be working now, but I can test it some more |
Member
|
@janfh i will test again. Thank you! |
worksofliam
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #380
Adds a second line in the tooltip when hovering the result view header that includes label or name depending on what is used in the header.
warning: manager.ts is modified to enable extended metadata by default (this is the same behaviour as ACS).