Added missing postDownload and deployFirst fields in action editor#3110
Added missing postDownload and deployFirst fields in action editor#3110sebjulliand wants to merge 6 commits intomasterfrom
postDownload and deployFirst fields in action editor#3110Conversation
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
|
👋 A new build is available for this PR based on f1f3b44. |
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
SanjulaGanepola
left a comment
There was a problem hiding this comment.
@sebjulliand The actual change in the PR is working as expected. But noticed some odd behavior when testing.
When editing local actions, for some reason the edits to the following are not being saved to the actions.json file:
Command(s) to runEnvironmentRefreshRun on protected/read only
Some of these don't seem to be editable on main either actually so likely unrelated to this PR. But Command(s) to run for example does work on main but not on this branch so semi-related 🤔
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
|
@SanjulaGanepola I fixed the command not being updated; that was a bug from this PR. Well spotted! By any chance, do you have actions with duplicated names in you local actions? That could explain the issue. |
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
postDownload field in action editorpostDownload and deployFirst fields in action editor
|
Added a checkbox in the editor for the |
Changes
Following up on #3109
This PR adds a Post Execution Downloads and a Deploy before running field to the Action editor for Local Actions only.

Other types of action will not display these fields in the editor.
These fields could only be added and edited manually from the settings/actions.json files.They can now also be changed from the editor.
The
postDownloadfield also now supports variables replacement when the action is executed.The PR also makes sure that some optional action fields are cleaned up before being saved to avoid writing blank strings/empty array in the settings.
How to test this PR
Checklist