Skip to content

Added missing postDownload and deployFirst fields in action editor#3110

Open
sebjulliand wants to merge 6 commits intomasterfrom
postDownloadActionEditorField
Open

Added missing postDownload and deployFirst fields in action editor#3110
sebjulliand wants to merge 6 commits intomasterfrom
postDownloadActionEditorField

Conversation

@sebjulliand
Copy link
Copy Markdown
Member

@sebjulliand sebjulliand commented Mar 12, 2026

Changes

Following up on #3109

This PR adds a Post Execution Downloads and a Deploy before running field to the Action editor for Local Actions only.
image

Other types of action will not display these fields in the editor.

These fields could only be added and edited manually from the settings/actions.json files.They can now also be changed from the editor.

The postDownload field also now supports variables replacement when the action is executed.

The PR also makes sure that some optional action fields are cleaned up before being saved to avoid writing blank strings/empty array in the settings.

How to test this PR

  1. Edit an action
  2. Set one or more post execution download paths
  3. Save
  4. The paths must be saved as an array in the settings
  5. Remove the paths
  6. Save
  7. The postDownload array must be removed from the settings

Checklist

  • have tested my change

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand sebjulliand requested a review from a team March 12, 2026 08:56
@sebjulliand sebjulliand self-assigned this Mar 12, 2026
@sebjulliand sebjulliand added the enhancement New feature or request label Mar 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 12, 2026

👋 A new build is available for this PR based on f1f3b44.

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Copy link
Copy Markdown
Member

@SanjulaGanepola SanjulaGanepola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand The actual change in the PR is working as expected. But noticed some odd behavior when testing.

When editing local actions, for some reason the edits to the following are not being saved to the actions.json file:

  • Command(s) to run
  • Environment
  • Refresh
  • Run on protected/read only

Some of these don't seem to be editable on main either actually so likely unrelated to this PR. But Command(s) to run for example does work on main but not on this branch so semi-related 🤔

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand
Copy link
Copy Markdown
Member Author

@SanjulaGanepola I fixed the command not being updated; that was a bug from this PR. Well spotted!
But I couldn't get the other fields to fail to be updated.

By any chance, do you have actions with duplicated names in you local actions? That could explain the issue.

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand sebjulliand changed the title Added missing postDownload field in action editor Added missing postDownload and deployFirst fields in action editor Mar 18, 2026
@sebjulliand
Copy link
Copy Markdown
Member Author

Added a checkbox in the editor for the deployFirst local actions field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants