Skip to content

return the search matches if code is not equal to zero #3114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebjulliand merged 4 commits into from
Mar 31, 2026
Merged

return the search matches if code is not equal to zero #3114

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5300599
return the search matches if code is not equal to zero
rapra41 Mar 17, 2026
3fc0ae2
small fix
rapra41 Mar 17, 2026
55f8282
removed else condition
rapra41 Mar 17, 2026
8917dd8
changed as requested
rapra41 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/api/SearchTools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,12 @@ export namespace SearchTools {
hits: parseGrepOutput(grepRes.stdout)
}
}
else if(grepRes.stdout!==undefined && grepRes.stdout!==""){
return {
term: searchTerm,
hits: parseGrepOutput(grepRes.stdout)
}
}
Copy link
Copy Markdown
Member

@sebjulliand sebjulliand Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not copy/pastecode and just test the new condition in the existing if. Testing grepRes.stdoutfor falsiness is enough, too.

Suggested change
}
if (grepRes.code === 0 || grepRes.stdout) {
return {
term: searchTerm,
hits: parseGrepOutput(grepRes.stdout)
}
}

} else {
throw new Error(`Grep must be installed on the remote system.`);
}
Expand Down