Skip to content

Fix regex for retrieving EVFEVENT info from joblog#3121

Merged
chrjorgensen merged 2 commits intocodefori:masterfrom
chrjorgensen:fix/evfeventf_regex
Mar 31, 2026
Merged

Fix regex for retrieving EVFEVENT info from joblog#3121
chrjorgensen merged 2 commits intocodefori:masterfrom
chrjorgensen:fix/evfeventf_regex

Conversation

@chrjorgensen
Copy link
Copy Markdown
Collaborator

Changes

This PR will fix the search for EVFEVENT in the joblog from an action. The regex was wrong and specified two consecutive spaces before EVFEVENT:.

The regex should be specify one or more spaces before EVFEVENT:.

Included is also a fix for the values used for the text "Fetching errors for..." - before this PR, the values used were the "guessed" ones and not the ones retrieved from the EVFEVENT in the joblog.

How to test this PR

  1. Run the test cases for the PR branch in Listen for EVFEVENT signals from server #2926
  2. Change the action TEST2 in Listen for EVFEVENT signals from server #2926 to include multiple spaces before EVFEVENT:.
  3. Run the final test case in Listen for EVFEVENT signals from server #2926 again - the info should still be picked up.

Checklist

  • have tested my change

@chrjorgensen chrjorgensen added this to the 3.0.0 milestone Mar 20, 2026
@chrjorgensen chrjorgensen self-assigned this Mar 20, 2026
@chrjorgensen chrjorgensen added the bug A confirmed issue when something isn't working as intended label Mar 20, 2026
Copy link
Copy Markdown
Member

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me! Merge whenever you want.
Just a small remark, but I'm being nitpicky !


for (const joblogLine of joblogLines) {
const evfevent = joblogLine.match(/: EVFEVENT:(.*)/i) || '';
const evfevent = joblogLine.match(/:[ ]+EVFEVENT:(.*)/i) || '';
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't even need the brackets here. But no biggie, that's just an FYI 😉

Suggested change
const evfevent = joblogLine.match(/:[ ]+EVFEVENT:(.*)/i) || '';
const evfevent = joblogLine.match(/: +EVFEVENT:(.*)/i) || '';

@chrjorgensen chrjorgensen merged commit fbaf027 into codefori:master Mar 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A confirmed issue when something isn't working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants