Fix regex for retrieving EVFEVENT info from joblog#3121
Merged
chrjorgensen merged 2 commits intocodefori:masterfrom Mar 31, 2026
Merged
Fix regex for retrieving EVFEVENT info from joblog#3121chrjorgensen merged 2 commits intocodefori:masterfrom
chrjorgensen merged 2 commits intocodefori:masterfrom
Conversation
sebjulliand
approved these changes
Mar 21, 2026
|
|
||
| for (const joblogLine of joblogLines) { | ||
| const evfevent = joblogLine.match(/: EVFEVENT:(.*)/i) || ''; | ||
| const evfevent = joblogLine.match(/:[ ]+EVFEVENT:(.*)/i) || ''; |
Member
There was a problem hiding this comment.
You don't even need the brackets here. But no biggie, that's just an FYI 😉
Suggested change
| const evfevent = joblogLine.match(/:[ ]+EVFEVENT:(.*)/i) || ''; | |
| const evfevent = joblogLine.match(/: +EVFEVENT:(.*)/i) || ''; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR will fix the search for EVFEVENT in the joblog from an action. The regex was wrong and specified two consecutive spaces before
EVFEVENT:.The regex should be specify one or more spaces before
EVFEVENT:.Included is also a fix for the values used for the text "Fetching errors for..." - before this PR, the values used were the "guessed" ones and not the ones retrieved from the EVFEVENT in the joblog.
How to test this PR
TEST2in Listen for EVFEVENT signals from server #2926 to include multiple spaces beforeEVFEVENT:.Checklist