Fix generic library filter#3122
Merged
sebjulliand merged 3 commits intocodefori:masterfrom Mar 21, 2026
Merged
Conversation
chrjorgensen
added
the
bug
chrjorgensen
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
sebjulliand
approved these changes
Mar 21, 2026
Member
sebjulliand
left a comment
sebjulliand
left a comment
There was a problem hiding this comment.
Good fix, thanks!
I didn't know QSYS needed to be padded in this case. The more you know!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR will fix an issue with retrieving libraries from filters with advanced generic names, e.g. starting with an asterisk.
Given this filter
the current code will return this:
With this PR the output is correct:
A regex filter is even worse - given this filter
you get no output:
but with this PR you get the correct list:
How to test this PR
Checklist