Add TallyItemForm with optional validation - #26
Open
MHUGGLER wants to merge 1 commit into
Open
Conversation
JMStudiosJoe
reviewed
Jun 2, 2026
| preventdefault:submit | ||
| class='flex flex-col gap-4 p-4' | ||
| > | ||
| <h2 class='text-xl font-bold'>Add Tally Item</h2> |
Contributor
There was a problem hiding this comment.
we should change this to be a instead since h tags should be carefully used and not used for styling purposes.
JMStudiosJoe
reviewed
Jun 2, 2026
| > | ||
| <h2 class='text-xl font-bold'>Add Tally Item</h2> | ||
|
|
||
| <input |
Contributor
There was a problem hiding this comment.
Could you please make this input field into a component as well for reuse?
JMStudiosJoe
requested changes
Jun 2, 2026
JMStudiosJoe
left a comment
JMStudiosJoe
left a comment
Contributor
There was a problem hiding this comment.
great work so far. a few changes and should be good to go thank you!
Contributor
|
Any updates on this pr? Just a couple minor changes then can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new TallyItemForm component for creating TallyItems in a TallyReport.
The form includes the required fields:
Features:
This is intended as a simple, extensible UI component as discussed in the issue.