Closed
Conversation
Bumps [rollup](https://github.com/rollup/rollup) from 4.44.1 to 4.59.1. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.44.1...v4.59.1) --- updated-dependencies: - dependency-name: rollup dependency-version: 4.59.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
averyjennings
requested changes
Mar 21, 2026
averyjennings
left a comment
averyjennings
left a comment
There was a problem hiding this comment.
Verdict: request-changes
The PR title and description claim to bump rollup from 4.44.1 to 4.59.1, but the actual lockfile diff does not update rollup — it remains at 4.44.1 in both the base branch and this PR branch.
What actually changed: get-tsconfig 4.13.0 → 4.13.6 (transitive dep of tsx via vitest). The rollup lockfile entry is identical on both sides.
Why this matters:
- Merging this creates a false record that rollup was updated to 4.59.1 (which includes the lazy dynamic import crash fix), when it wasn't.
- If rollup actually needs to be bumped (e.g., to get the 4.59.1 crash fix), this PR won't accomplish it.
Suggested next steps:
- Comment
@dependabot recreateto have dependabot regenerate the PR with a fresh lockfile resolution. - Or close this and open a targeted PR that explicitly updates the rollup constraint in
package.json.
The get-tsconfig bump is safe and could stand on its own as a tiny maintenance commit, but it shouldn't be merged as a misleadingly-framed rollup update.
Contributor
Author
|
Superseded by #109. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps rollup from 4.44.1 to 4.59.1.
Release notes
Sourced from rollup's releases.
... (truncated)
Changelog
Sourced from rollup's changelog.
... (truncated)
Commits
0cba9e04.59.14eeea29Pin Vite1cd49aefix: fix chunk assignment for deoptimized module with dynamic import (#6306)c9dabc3Downgrade Vited46200fchore(deps): update dependency vite to v8 (#6309)aa6c853chore(deps): update dependency lru-cache to v11 (#6308)4208811chore(deps): lock file maintenance (#6312)5348a82chore(deps): lock file maintenance (#6311)c942b8dchore(deps): update minor/patch updates (#6307)bf9d35cchore(deps): lock file maintenance (#6310)Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for rollup since your current version.
Install script changes
This version modifies
preparescript that runs during installation. Review the package contents before updating.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.