Skip to content

SANDBOX-1769 | feature: expose "disabled integrations" in the UIConfig#590

Open
MikelAlejoBR wants to merge 1 commit intocodeready-toolchain:masterfrom
MikelAlejoBR:SANDBOX-1769-feature-enabled-integrations-rs
Open

SANDBOX-1769 | feature: expose "disabled integrations" in the UIConfig#590
MikelAlejoBR wants to merge 1 commit intocodeready-toolchain:masterfrom
MikelAlejoBR:SANDBOX-1769-feature-enabled-integrations-rs

Conversation

@MikelAlejoBR
Copy link
Copy Markdown
Contributor

@MikelAlejoBR MikelAlejoBR commented Apr 10, 2026

In order for the UI to be able to consume the field, the registration service needs to expose it via the REST API.

Related PRs

Jira ticket

[SANDBOX-1769]

Summary by CodeRabbit

  • New Features
    • API configuration endpoint now exposes a disabled integrations list in its response (clients receive an empty list when none are configured).
  • Tests
    • Added/updated tests to verify the disabled integrations field defaults to an empty list and reflects configured values.

@openshift-ci openshift-ci Bot requested review from MatousJobanek and fbm3307 April 10, 2026 20:37
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 10, 2026

Warning

Rate limit exceeded

@MikelAlejoBR has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 44 minutes and 41 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 44 minutes and 41 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: af839b6a-8bae-4c3e-839b-dad7acb3878f

📥 Commits

Reviewing files that changed from the base of the PR and between 3e398b0 and 3a9387d.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (4)
  • go.mod
  • pkg/configuration/configuration.go
  • pkg/controller/uiconfig.go
  • pkg/controller/uiconfig_test.go

Walkthrough

Adds a DisabledIntegrations() accessor to the registration service configuration and surfaces its value as disabledIntegrations in the UI config HTTP response; tests added to assert default empty slice and configured values.

Changes

Cohort / File(s) Summary
Configuration accessor
pkg/configuration/configuration.go
Added DisabledIntegrations() method on RegistrationServiceConfig that returns r.cfg.Host.RegistrationService.DisabledIntegrations or a non-nil empty []string{} when nil.
UI config response & handler
pkg/controller/uiconfig.go
Added DisabledIntegrations []string 'json:"disabledIntegrations"' to UIConfigResponse and populated it in (*UIConfig).GetHandler using cfg.DisabledIntegrations().
Tests
pkg/controller/uiconfig_test.go
Extended TestUIConfigHandler to assert default empty disabledIntegrations and added TestUIConfigHandlerWithDisabledIntegrations to verify configured values are returned.
Module dependency
go.mod
Updated github.com/codeready-toolchain/api version reference.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: exposing a 'disabled integrations' field in the UIConfig, which aligns with all file modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

In order for the UI to be able to consume the field, the registration
service needs to expose it via the REST API.

SANDBOX-1769
@MikelAlejoBR MikelAlejoBR force-pushed the SANDBOX-1769-feature-enabled-integrations-rs branch from 3e398b0 to 3a9387d Compare April 17, 2026 14:52
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikelAlejoBR
Copy link
Copy Markdown
Contributor Author

Good point, thank you!

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MikelAlejoBR

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants