Merged
Conversation
…ior in TapeInfos. BufferState is used as RAII type for what was before stored as separate file pointer, pointer-to-first, pointer-to-current, pointer-to-last and a corresponding number-of-elements-stored; for operations values, locations and taylor coefficients. All four are now represented by a corresponding BufferState that handles the file resources, allocations and indices. Additionally, several Buffer write and read patters are summarized. All changes should make the code more robust and readable.
TimSiebert1
force-pushed
the
introduce-buffer-type
branch
from
78ac29e to
af2b216
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce BufferState class to summarize common state and behavior in TapeInfos.
BufferState is used as RAII type for what was before stored as separate file pointer, pointer-to-first, pointer-to-current, pointer-to-last and a corresponding number-of-elements-stored; for operations values, locations and taylor coefficients. All four are now represented by a corresponding BufferState that handles the file resources, allocations and indices. Additionally, several Buffer write and read patters are summarized. All changes should make the code more robust and readable.