Update windows-ci for action update for Node.js 24 to set up msvc#212
Merged
jhmgoossens merged 1 commit intocoin-or:masterfrom Apr 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The windows-ci.yml for masters and stables of many coin-or projects use the
But this action msvc-dev-cmd still uses Node.js 20. This results in Warnings in the action Runs like:
I propose that instead of
uses: ilammy/msvc-dev-cmd@v1we useuses: egor-tensin/vs-shell@v2. This vs-shell action is light-weight and does not use Node.js. Test runs show that such runs work and produce the same binaries. The maintainer is active, even if this action itself has not had recent releases.See also COIN-OR-OptimizationSuite Issue 37