Skip to content

Update windows-ci for action update for Node.js 24 to set up msvc#212

Merged
jhmgoossens merged 1 commit intocoin-or:masterfrom
jhmgoossens:dev-ci-msvcdev-202604-master
Apr 20, 2026
Merged

Update windows-ci for action update for Node.js 24 to set up msvc#212
jhmgoossens merged 1 commit intocoin-or:masterfrom
jhmgoossens:dev-ci-msvcdev-202604-master

Conversation

@jhmgoossens
Copy link
Copy Markdown
Contributor

The windows-ci.yml for masters and stables of many coin-or projects use the

      - name: Set up msvc
        if: ${{ matrix.arch == 'msvc' }}
        uses: ilammy/msvc-dev-cmd@v1

But this action msvc-dev-cmd still uses Node.js 20. This results in Warnings in the action Runs like:

Node.js 20 actions are deprecated. The following actions are running on Node.js 20 
and may not work as expected: ilammy/msvc-dev-cmd@v1.

I propose that instead of uses: ilammy/msvc-dev-cmd@v1 we use uses: egor-tensin/vs-shell@v2. This vs-shell action is light-weight and does not use Node.js. Test runs show that such runs work and produce the same binaries. The maintainer is active, even if this action itself has not had recent releases.

See also COIN-OR-OptimizationSuite Issue 37

@jhmgoossens jhmgoossens self-assigned this Apr 19, 2026
@jhmgoossens jhmgoossens merged commit 291b62a into coin-or:master Apr 20, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant