Skip to content

fix: discover non Cargo packages in a Cargo workspace#64

Open
esteve wants to merge 2 commits intocolcon:mainfrom
esteve:discover-non-cargo-packages
Open

fix: discover non Cargo packages in a Cargo workspace#64
esteve wants to merge 2 commits intocolcon:mainfrom
esteve:discover-non-cargo-packages

Conversation

@esteve
Copy link
Copy Markdown
Contributor

@esteve esteve commented Aug 8, 2025

This PR adds discovery of non-Cargo packages in a Cargo workspace.

Fixes #63

@esteve
Copy link
Copy Markdown
Contributor Author

esteve commented Aug 8, 2025

I ran both the Black and Ruff formatters and both replace single quotes with double ones, I'll revert those changes but I wonder if it'd better to update flake8 to match Black and Ruff since both have become the standard for Python formatting.

Signed-off-by: Esteve Fernandez <esteve@apache.org>
@esteve esteve force-pushed the discover-non-cargo-packages branch from 0122363 to f334adc Compare August 8, 2025 20:34
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.70%. Comparing base (ec2b28b) to head (8b12840).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   72.22%   72.70%   +0.47%     
==========================================
  Files           9        9              
  Lines         342      348       +6     
  Branches       59       60       +1     
==========================================
+ Hits          247      253       +6     
  Misses         61       61              
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@esteve esteve requested a review from cottsay August 8, 2025 20:40
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Bug: package discovery nested cmake project

2 participants