fix: discover non Cargo packages in a Cargo workspace#64
Open
esteve wants to merge 2 commits intocolcon:mainfrom
Open
fix: discover non Cargo packages in a Cargo workspace#64esteve wants to merge 2 commits intocolcon:mainfrom
esteve wants to merge 2 commits intocolcon:mainfrom
Conversation
Contributor
Author
|
I ran both the Black and Ruff formatters and both replace single quotes with double ones, I'll revert those changes but I wonder if it'd better to update flake8 to match Black and Ruff since both have become the standard for Python formatting. |
50aafeb to
86ae247
Compare
86ae247 to
0122363
Compare
Signed-off-by: Esteve Fernandez <esteve@apache.org>
0122363 to
f334adc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 72.22% 72.70% +0.47%
==========================================
Files 9 9
Lines 342 348 +6
Branches 59 60 +1
==========================================
+ Hits 247 253 +6
Misses 61 61
Partials 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Esteve Fernandez <esteve@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds discovery of non-Cargo packages in a Cargo workspace.
Fixes #63