fix: escape JSON Pointer tokens in toJSONSchema $ref (RFC 6901)#6051
Open
godfengliang wants to merge 1 commit into
Open
fix: escape JSON Pointer tokens in toJSONSchema $ref (RFC 6901)#6051godfengliang wants to merge 1 commit into
godfengliang wants to merge 1 commit into
Conversation
Contributor
|
Run failed. View the logs →
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #6027
Problem
When a schema id contains
/or~characters, the$refURI fragment was not being escaped per RFC 6901 (JSON Pointer):~should become~0/should become~1For example, with id
Shared/User~, the$refwas:#/$defs/Shared/User~(incorrect)Now correctly produces:
#/$defs/Shared~1User~0The
$defsobject key remains unescaped (as it's a plain JSON object key, not a JSON Pointer).Fix
Apply
split("~").join("~0").split("/").join("~1")to the defId in both$refconstruction paths inextractDefs:Testing
Verified with three test cases:
id: "Shared/User~"->$ref: "#/$defs/Shared~1User~0"✓id: "MySchema"->$ref: "#/$defs/MySchema"✓ (no change for normal ids)id: "My~Schema"->$ref: "#/$defs/My~0Schema"✓