Add gs_usb support in Windows build to support CANable, CAN Bus Debugger CANtact devices

[BennyEvans]

As discussed in Issue #238 this PR adds support for devices utilising the gs_usb protocol on Windows.

The dll that supports the protocol is licenced under the LGPL and so is appropriately compiled separately and linked dynamically. The source for the dll is available here: https://github.com/BennyEvans/candle_dll

I've tested with CANable and CAN Bus Debugger devices and with both at the same time without issue.

For transparency sake, it's worth noting that I'm the main developer of the CAN Bus Debugger device.

Let me know if there is anything that needs to be modified. I think it'll be great to add this support to the application.

Thanks again!
Ben

[BennyEvans]

It's also worth noting that the DLL/licence will need to be copied into the appropriate place to be distributed with a Windows release.

[collin80]

Thanks, I want to merge this but I'll probably hold off until I have time to also configure the continuous build to package the DLL properly.

[liamkinne]

Hello, is there anything I can do to help get this merged soon? Windows support for my products that use gs_usb would be great.

[BennyEvans]

I'm also happy to help with whatever is needed to get this pushed through.

@liamkinne we've not met before but I'm also based in Australia and I believe we have some mutual connections. Would be keen to catch up.

[Monroe07]

Can you upload a windows release for this branch? I've been trying to see if this branch will work for what I'm trying to do, and I cannot for the life of me get it to build.

[BennyEvans]

@Monroe07 appologies, I missed your message. Can you get the main branch to build? What's the error you're getting.

I'm not at a computer with Qt installed right now but will try to attach something over the next few days.

EDIT: Here it is, built against the latest changes (updated from comments below to include required DLLs):
SavvyCAN_gs_usb.zip

[BennyEvans]

@collin80 is there anything I can assist with to get this merged?

I'm happy to resolve the conflicts at some point in the next few days.

EDIT: I've fixed the conflicts and the branch is now based on top of main.

[liamkinne]

@collin80 can we please get an updated ETA on when this will be merged? Thanks.

[Citizen07]

I would like to test SavvyCAN with gs_usb support on Windows. Tried using SavvyCAN_test.zip provided above but couldn't get it to launch. @BennyEvans could you give me basic step by step guide to get it working?

[BennyEvans]

@Citizen07 do you get an error at all?

You should just be able to extract the zip file and run it. Perhaps I've not compiled SavvyCAN it in a portable format - I don't use Qt much.

[Citizen07]

I get these if I try to run it after extracting, Qt5*.dll errors gets resolved by adding Qt5 files from Savvy release build, but other 2 remains

[BennyEvans]

@Citizen07 I think it may be because I compile with MinGW on windows and I haven't statically linked the stdlib libraries.

So we don't clog up the PR comments here, send me an email at ben@canbusdebugger.com and I'll keep helping you out there. We can update back here once it's all working for you.

UPDATE: I've updated the attached compiled test version in the comment above to include all the required dlls and have confirmed this works on a fresh Windows 11 install with the original canable device. With the help of Citizen07, it looks like there is an incompatibility with the canable 2.0 (a CAN FD device) which I can look into if/when I get a canable 2.0 so that this PR helps people with wider range of gs_usb devices. However, this should not prevent the PR from being merged as non canable 2.0 devices work as expected.