chore(lua): remove lua plugin#332
Merged
Merged
Conversation
yaml.v3's lenient unmarshal behavior is a stable upstream guarantee; an ad-hoc test in our config package isn't earning its keep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hive.commands,hive.http,hive.json,hive.kv,hive.logger,hive.sh,hive.ticker,hive.info),LuaPluginConfig, thehive plugin initscaffolder, integration tests, and docs.github.com/yuin/gopher-luafrom the module graph.CommandSet.MergePluginandManager.Pool()are gone; the seeding flow no longer needs the Lua re-init dance.Why
The Lua plugin was an experiment in user-extensible commands that hasn't paid for its surface area. Removing it cuts a runtime, a dependency, a config block, a CLI subcommand, and ~7k lines of code+docs+tests with no migration path needed.
Phased commits
Each phase is a self-contained commit; build is intentionally broken between Phase 1 and Phase 3, then restored.
internal/hive/plugins/lua/(25 files, -5629)LuaPluginConfig+ validatorsmain.go+ plugin manager, dropMergePlugin/Pool()— build restoredhive plugin initcommand +defaultPluginsDir()docs/configuration/plugins.mdLua section, NeoVim comparison)go mod tidy— removesgopher-luaFull plan:
.hive/plans/2026-05-11-remove-lua-plugin.md.Test plan
mise exec go@1.26 -- go build ./...passesmise exec go@1.26 -- go test ./...passesmise exec go@1.26 -- go test -tags integration ./test/integration/...passesmise run lintexits 0 (after chore(lint): remove goconst linter #331)mise run docs:buildsucceedsmise container—hv --helpshows nopluginsubcommand, TUI palette opens,hv doctorexits 0, andHIVE_CONFIG=<yaml with plugins.lua>is silently ignored