Open
Conversation
…nto FU-3661/update-to-guzzle6 Conflicts: .scrutinizer.yml
[FU-3661] Update to guzzle6
|
👍 The build fails because Guzzle requires PHP 5.5 as minimum versions and the only test that fails on Travis is the one on PHP 5.4... All the others pass... |
Fix scrutinizer/travis issues
Open
|
@lemasson-h Would you please rebase from master and squash your commits? It is now quite hard to see the changes you made. |
| @@ -32,36 +24,33 @@ First make sure you have all the dependencies in place by running `composer inst | |||
| use GuzzleHttp\Client; | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here an approach to try to be as close as possible to the previous version adapted for guzzle6.
Would you be happy with that?