Skip to content

fix(setup): correctly auto-detect username when using --full - #11650

Merged
tremor021 merged 1 commit into
community-scripts:mainfrom
ls-root:fix/full-flag
Feb 7, 2026
Merged

fix(setup): correctly auto-detect username when using --full#11650
tremor021 merged 1 commit into
community-scripts:mainfrom
ls-root:fix/full-flag

Conversation

@ls-root

@ls-root ls-root commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

✍️ Description

Argument parsing prevented auto-detection from running when --full was supplied without an explicit username. After shifting --full, no positional arguments remained, but the script had already skipped the auto-detection branch, leaving USERNAME empty and causing the script to abort.

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

Argument parsing prevented auto-detection from running when --full
was supplied without an explicit username. After shifting --full,
no positional arguments remained, but the script had already skipped
the auto-detection branch, leaving USERNAME empty and causing the
script to abort.
@MickLesk MickLesk added the github label Feb 7, 2026
@tremor021
tremor021 merged commit e27dc1c into community-scripts:main Feb 7, 2026
1 check passed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants